Added table of dependencies versions to README#2183
Merged
Conversation
Signed-off-by: Edoardo Pasca <14138589+paskino@users.noreply.github.com>
paskino
changed the title
casperdcl
requested changes
Jul 8, 2025
Member
|
Do we want to also update the conda instructions to use the env files here: Hannah has drafted something here: |
Signed-off-by: Edoardo Pasca <14138589+paskino@users.noreply.github.com>
Signed-off-by: Edoardo Pasca <14138589+paskino@users.noreply.github.com>
Signed-off-by: Edoardo Pasca <14138589+paskino@users.noreply.github.com>
hrobarts
reviewed
Jul 30, 2025
hrobarts
reviewed
Jul 30, 2025
casperdcl
requested changes
Aug 1, 2025
Co-authored-by: Casper da Costa-Luis <casper.dcl@physics.org> Signed-off-by: Hannah Robarts <77114597+hrobarts@users.noreply.github.com>
Signed-off-by: Hannah Robarts <77114597+hrobarts@users.noreply.github.com>
casperdcl
reviewed
Aug 5, 2025
Signed-off-by: Casper da Costa-Luis <casper.dcl@physics.org>
casperdcl
reviewed
Aug 5, 2025
Signed-off-by: Casper da Costa-Luis <casper.dcl@physics.org>
casperdcl
reviewed
Aug 6, 2025
casperdcl
reviewed
Aug 6, 2025
casperdcl
reviewed
Aug 6, 2025
Co-authored-by: Casper da Costa-Luis <casper.dcl@physics.org> Signed-off-by: Hannah Robarts <77114597+hrobarts@users.noreply.github.com>
hrobarts
reviewed
Aug 8, 2025
gfardell
approved these changes
Aug 8, 2025
Member
gfardell
left a comment
gfardell
left a comment
There was a problem hiding this comment.
It seems very clear to me! I think it's a good change. The tested versions we can update as we iterate.
Signed-off-by: Hannah Robarts <77114597+hrobarts@users.noreply.github.com>
Signed-off-by: Hannah Robarts <77114597+hrobarts@users.noreply.github.com>
hrobarts
approved these changes
Aug 11, 2025
casperdcl
reviewed
Aug 11, 2025
Signed-off-by: Edoardo Pasca <14138589+paskino@users.noreply.github.com>
Signed-off-by: Edoardo Pasca <14138589+paskino@users.noreply.github.com>
Signed-off-by: Edoardo Pasca <14138589+paskino@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After discussion with @hrobarts we decided to not remove the original conda install commands as the new proposed one didn't seem simple.
Also the old text made clear what the role of the additional dependencies is and even how to get ASTRA for CPU or GPU.
We added the new command pointing to the environment file with the instruction that it was installing the software necessary for CIL-Demos with tested versions.
Checklist
Contribution Notes
Please read and adhere to the developer guide and local patterns and conventions.